TAMP/OCTOSPI/LTDC #1226
Open
TAMP/OCTOSPI/LTDC #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37b0a2a to
b4d7aee
Compare
|
cc @usbalbin |
usbalbin
reviewed
May 11, 2025
Comment on lines
+239
to
+248
| OCTOSPI1: | ||
| WCCR: | ||
| _modify: | ||
| IMODE: | ||
| bitWidth: 3 | ||
| IDTR: | ||
| bitOffset: 3 | ||
| ISIZE: | ||
| bitOffset: 4 | ||
| bitWidth: 2 |
There was a problem hiding this comment.
At what point should things like this get its own file? I see it is the same for all rm0455 devices
usbalbin
reviewed
May 11, 2025
| _include: | ||
| - patches/octospi/h7.yaml | ||
| - fields/octospi/l5.yaml |
There was a problem hiding this comment.
Should this still be named l5.yaml when used by other series?
usbalbin
approved these changes
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.