Fix L412 RCC SMENR reset values, fix interrupts #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
reviewed
Jun 2, 2025
burrbull
previously approved these changes
Jun 2, 2025
auto-merge was automatically disabled
June 2, 2025 06:47
Head branch was pushed to by a user without write access
|
Squash commits, please. |
|
@burrbull Hi, can you review again please |
burrbull
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My program wasn't running correctly because the
RCC AHB1SMENRregister doesn't have the correct reset value. I dumped the reset values for all the SMENR registers and edited the patch for them.I also fixed some of the other interrupts I previously noticed were wrong: