-
Notifications
You must be signed in to change notification settings - Fork 243
Add RAMECC registers across the H7 family #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can we just define RAMECC1 and have 2 and 3 derive from that, rather than redefining the registers for each one? |
RAMECC was 'added' to the single core parts in RM0433 Rev 7. For the dual core parts there are definitions, but they are so terrible it's worth starting over. (there's registers with the wrong address and wrong fields) The RAMECC2 and RAMECC3 registers are derived from RAMECC1. RAMECC3 only has two useful monitor channels, but there seems to be no harm in accessing the remaining channels. For a use case, there is at least one set of commercial spaceflight hardware using the H7: (no affiliation, no endorsement intended) - [Nanoavionics OBC](https://nanoavionics.com/cubesat-components/cubesat-on-board-computer-main-bus-unit-satbus-3c2/)
Yup, done. RAMECC3 only has two monitors connected, but I assume its safe to access the remaining monitor registers.. |
On a real target (H747), RAMECC3.M[3-5]CR locations are not really registers (they don't read what was just written to them). I think the easiest solution to only keep RAMECC3.M[1-2]* is to keep the separate |
RAMECC3 only has two monitoring units
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm!
bors r+
353: Add RAMECC registers across the H7 family r=adamgreig a=richardeoin RAMECC was 'added' to the single core parts in RM0433 Rev 7. For the dual core parts there are definitions in the SVD, but they are so terrible it's worth starting over (there are registers with the wrong address, and the wrong fields) For a use case, there is at least one set of commercial spaceflight hardware using the H7: (no affiliation, no endorsement intended) - [Nanoavionics OBC](https://nanoavionics.com/cubesat-components/cubesat-on-board-computer-main-bus-unit-satbus-3c2/) Co-authored-by: Richard Meadows <962920+richardeoin@users.noreply.github.com>
Timed out |
bors retry |
Build succeeded
|
RAMECC was 'added' to the single core parts in RM0433 Rev 7. For the dual core parts there are definitions in the SVD, but they are so terrible it's worth starting over (there are registers with the wrong address, and the wrong fields)
For a use case, there is at least one set of commercial spaceflight hardware using the H7:
(no affiliation, no endorsement intended)