Skip to content

Fix cargo feature list for stm32g0 series #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2021
Merged

Conversation

ijager
Copy link
Contributor

@ijager ijager commented Sep 24, 2020

No description provided.

@github-actions
Copy link

Memory map comparison

@adamgreig
Copy link
Member

Thanks for fixing this. Is there much difference between the 070 and 071 that warrants including both? I'm worried that having all those features will increase memory usage beyond the current 3GB limit, which would cause builds to fail. If 070 is a subset of 071, perhaps we could only include 071 in the docs?

@ijager
Copy link
Contributor Author

ijager commented Sep 24, 2020

Yes there are a lot of differences between G070 and G071. There are less differences between G081 and G071. The G081 and G041 versions add AES stuff. Here is a nice overview of the differences: https://github.com/stm32-rs/stm32g0xx-hal#g0-hardware-overview

So perhaps we could remove G071 and G031 as those are subsets of G081 and G041 respectively.

@ijager
Copy link
Contributor Author

ijager commented Sep 24, 2020

And I guess G030 is a subset of G070

@adamgreig
Copy link
Member

It looks like we need to request some memory limit increases for other crates anyway (#443) so I'll test out how much RAM this PR requires and see if we can just build it as-is first.

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait on this. I'm going to merge your PR and then remove the subset devices (030, 031, 071 perhaps) until we get under the memory limit, since I plan to publish a new version within a few days.

bors merge

@bors bors bot merged commit d390e17 into stm32-rs:master Feb 13, 2021
@adamgreig
Copy link
Member

I measured 2.7GB for the current features, hopefully this will build OK as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants