Skip to content

Add CORDIC math function accelerator support to stm32g4 #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2021
Merged

Add CORDIC math function accelerator support to stm32g4 #485

merged 2 commits into from
Feb 1, 2021

Conversation

pawelchcki
Copy link
Contributor

@pawelchcki pawelchcki commented Jan 31, 2021 •
edited
Loading

Add CORDIC math accellerator enum definitions to stm32g4 family
- modified description on mislabeled registiers
- added clarifying descriptions for two CORDICs CSR fields

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@pawelchcki pawelchcki marked this pull request as ready for review January 31, 2021 22:29
@pawelchcki pawelchcki changed the title Add CORDIC math function accelerator support Add CORDIC math function accelerator support to stm32g4 Jan 31, 2021
@pawelchcki
Add CORDIC math accellerator enum definitions to stm32g4
de41b8e 
+ modified description on mislabeled registiers
+ added clarifying descriptions for two CORDICs CSR fields
@github-actions
Copy link

Memory map comparison

adamgreig
adamgreig requested changes Feb 1, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good! I just noticed a few small changes/comments, otherwise this is ready to merge.

@pawelchcki @adamgreig
Apply suggestions from code review
d1ac040 
Fix two errors, and use Bits32, Bits16 as size enums

Co-authored-by: Adam Greig <adam@adamgreig.com>
@github-actions
Copy link

github-actions bot commented Feb 1, 2021

Memory map comparison

@pawelchcki
Copy link
Contributor Author

Thanks @adamgreig for fast and thorough review! 🙇‍♂️
Applied all suggestions. Should be ready for another review round.

@pawelchcki pawelchcki requested a review from adamgreig February 1, 2021 18:07
@adamgreig
Copy link
Member

Great, thanks!

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 1, 2021

Build succeeded:

@bors bors bot merged commit 5694a78 into stm32-rs:master Feb 1, 2021
@pawelchcki pawelchcki deleted the add_cordic_g4 branch February 1, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawelchcki @adamgreig