Skip to content

Fixed ch17 and ch18 in ADC COMMON for STM32L4x5 #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2021
Merged

Fixed ch17 and ch18 in ADC COMMON for STM32L4x5 #491

merged 1 commit into from
Feb 6, 2021

Conversation

korken89
Copy link
Contributor

@korken89 korken89 commented Feb 5, 2021 •
edited
Loading

I noticed when extending the STM32L4xx HAL that this MCU had some bits with different names compared to the rest of the series.
This PR fixes this.

@korken89 korken89 changed the title Added ch17 and ch18 in ADC COMMON Added ch17 and ch18 in ADC COMMON for STM32L4x5 Feb 5, 2021
@github-actions
Copy link

github-actions bot commented Feb 5, 2021

Memory map comparison

@github-actions
Copy link

github-actions bot commented Feb 5, 2021

Memory map comparison

@korken89 korken89 changed the title Added ch17 and ch18 in ADC COMMON for STM32L4x5 Fixed ch17 and ch18 in ADC COMMON for STM32L4x5 Feb 5, 2021
@korken89
Copy link
Contributor Author

korken89 commented Feb 5, 2021

Ready for review!

adamgreig
adamgreig approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Annoying that ST aren't more consistent here, sometimes the fields are TSEN/VBATEN on other devices, but CH17SEL/CH18SEL clearly matches the RM and the other L4, so let's go with this.

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 6, 2021

Build succeeded:

@bors bors bot merged commit 03ba282 into stm32-rs:master Feb 6, 2021
@korken89 korken89 deleted the stm32l4x5_adc_common_missing_fields branch February 6, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korken89 @adamgreig