Skip to content

Fix name of bit fields LPVAE and LPHFPE in DSIHOST VMCR for STM32F469 #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix name of bit fields LPVAE and LPHFPE in DSIHOST VMCR for STM32F469 #543

wants to merge 2 commits into from

Conversation

Jsbjr
Copy link

@Jsbjr Jsbjr commented Apr 18, 2021

No description provided.

@Jsbjr Jsbjr mentioned this pull request Apr 18, 2021
Closed
@github-actions
Copy link

Memory map comparison

@burrbull
Copy link
Member

burrbull commented Apr 18, 2021 •
edited
Loading

What about change it with:

DSIHOST:
  _strip:
    - "DSI_"
  VMCR:
    _modify:
      LVAE:
        name: LPVAE
      LPHFE:
        name: LPHFPE

This will remove unneeded "DSI_" prefix from all registers.

@Jsbjr
Copy link
Author

Jsbjr commented Apr 18, 2021 •
edited
Loading

Striping DSI_ would make sense.
This appear in all those files:

svd/stm32mp157.svd.patched
svd/stm32wb55.svd.patched
svd/stm32l4r9.svd.patched
svd/stm32h747cm7.svd.patched
svd/stm32h743v.svd.patched
svd/stm32h7b3.svd.patched
svd/stm32h743.svd.patched
svd/stm32g081.svd.patched
svd/stm32h753v.svd.patched
svd/stm32h753.svd.patched
svd/stm32g071.svd.patched
svd/stm32g070.svd.patched
svd/stm32h747cm4.svd.patched
svd/stm32g041.svd.patched
svd/stm32g030.svd.patched
svd/stm32g031.svd.patched
svd/stm32f7x9.svd.patched
svd/stm32f7x7.svd.patched
svd/stm32f765.svd.patched
svd/stm32f745.svd.patched
svd/stm32f469.svd.patched

If it is done it is probably nicer to do it on all of these devices.

@burrbull
Copy link
Member

Then place this patch in separate file in common_patches and include it from all these device yaml's.

improve consistency and naming of dsi modules and registers
a82a68d 
Rename DSIHOST and DSIHOST1 to DSI
Remove DSI_ prefix of all DSI registers
@github-actions
Copy link

Memory map comparison

@Jsbjr
Copy link
Author

Jsbjr commented Apr 18, 2021

Actually there are not that much DSI modules as I expected.
I had lots of false positives, searching for the DSI_ prefix was not spot on.
Now I'm not sure if 5 files is a common enough occurrence to justify a common patch script.

@burrbull
Copy link
Member

cc @adamgreig

@adamgreig
Copy link
Member

@burrbull is this now done by #540?

@burrbull
Copy link
Member

Partially as I can see.

@burrbull burrbull mentioned this pull request Jul 22, 2021
Merged
bors bot added a commit that referenced this pull request Jul 22, 2021
@bors @burrbull
Merge #585
3477ebf 
585: strip DSI r=adamgreig a=burrbull

Instead of #543 

Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@adamgreig
Copy link
Member

Closed by #585, thanks @Jsbjr!

@adamgreig adamgreig closed this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jsbjr @burrbull @adamgreig