-
Notifications
You must be signed in to change notification settings - Fork 244
Fix wrong bit offset of CRCEN/CRCRST/CRCSMEN and USARTXSMEN for L4 family #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR! It all looks correct, except the field at bit 19 of APB1SMENR1 is called UART4SMEN (UART not USART). This is very tedious, but there's also some very similar errors for L4x1 and L4x2. It would be good to have these in the PR also:
|
@richardeoin Sorry for the late reply. Fixed up the rename. Regarding the USART1EN -> USART3EN rename, that is already part of the l4x1 and l4x2 patches from what I an see. (Line 12-14 in stm32l4x1.yaml for instance). |
Indeed the USART1EN -> USART3EN rename is being applied for the l4x2 already - I missed that. For the l4x1 it should be applied but the original patches have an error - there's two Actually this PR has the same error with two |
cc66054
to
84edae9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good now!
bors r+
Various SVD fixes to L4 chips.