Skip to content

stm32f7x7: Fix missing fields for timers #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

stm32f7x7: Fix missing fields for timers #597

wants to merge 1 commit into from

Conversation

maximeborges
Copy link
Member

A lot of fields are wrong or missing for the timers for the STM32F7x7.
This pull request fix all of them regarding their definitions in the reference manual.

@github-actions
Copy link

Memory map comparison

@adamgreig
Copy link
Member

Thank you!

Often when one device is wrong like this the related devices (f7x6 and f7x9 especially but maybe other f7) have the exact same problems, so it might be worth a quick check to see and then these patches could go into a common patch file included in both. Would you mind having a look?

@maximeborges
Copy link
Member Author

Often when one device is wrong like this the related devices (f7x6 and f7x9 especially but maybe other f7) have the exact same problems, so it might be worth a quick check to see and then these patches could go into a common patch file included in both. Would you mind having a look?

I'll check tomorrow if I have some time.

The CI is failing with the error:

svdtools.patch.SvdPatchError: register CCMR1_Output already has a field OC1M_3

Do you have any idea why the CI is failing but I can't reproduce the error locally ?

maximeborges
maximeborges commented Aug 17, 2021
View reviewed changes
devices/stm32f7x7.yaml
bitOffset: 10
bitWidth: 2

# This is not working?!
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this seems to not be applied, neither in the doc nor in the code.
Any idea ?

@maximeborges
Copy link
Member Author

maximeborges commented Aug 18, 2021 •
edited
Loading

Superseded by #546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximeborges @adamgreig