Skip to content

clear in h7b3 RSR #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2021
Merged

clear in h7b3 RSR #601

merged 1 commit into from
Aug 26, 2021

Conversation

burrbull
Copy link
Member

No description provided.

@github-actions
Copy link

Memory map comparison

@adamgreig
Copy link
Member

What's the purpose of clearing the RSTF fields? From a quick look none of them seem to have any enumeratedValues or writeConstraints anyway?

@burrbull
Copy link
Member Author

burrbull commented Aug 26, 2021

This is not true. They have autogenerated enums.
And they block rule from peripherals/rcc/rcc_v3 to be correctly applied.

In https://github.com/stm32-rs/svdtools/pull/74 I've changed sorted_fields to use bitOffset instead of natural_keys which works better in most of cases.
Merge both, please.

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks like I was somehow looking at an old version of the SVD.

bors merge

@burrbull
Copy link
Member Author

ST gave us a big headache with those new autogenerated enums

@bors bors bot merged commit a68e1dc into stm32-rs:master Aug 26, 2021
@burrbull burrbull deleted the h7b3-rsr branch August 14, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants