Skip to content

Fix address offsets on H743/V DFSDM #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 2, 2021
Merged

Conversation

David-OConnor
Copy link
Contributor

Addresses #636

@David-OConnor David-OConnor marked this pull request as draft October 2, 2021 14:26
@github-actions
Copy link

github-actions bot commented Oct 2, 2021

Memory map comparison

@github-actions
Copy link

github-actions bot commented Oct 2, 2021

Memory map comparison

@github-actions
Copy link

github-actions bot commented Oct 2, 2021

Memory map comparison

@github-actions
Copy link

github-actions bot commented Oct 2, 2021

Memory map comparison

@github-actions
Copy link

github-actions bot commented Oct 2, 2021

Memory map comparison

@David-OConnor David-OConnor marked this pull request as ready for review October 2, 2021 15:53
@github-actions
Copy link

github-actions bot commented Oct 2, 2021

Memory map comparison

@adamgreig
Copy link
Member

It looks like only the 743/743v use the names you've got in the file, the other H7 series use names either without the DFSDM prefix for the common registers like CH0CFGR1, or with it for the filter block ones like DFSDM_FLT0CR1. What a pain! I think the patch file you've got now is good for the 743/743v, but the other H7s probably just need the _strip: DFSDM alone and I don't think anything else?

@David-OConnor
Copy link
Contributor Author

Done: Strip for non-H743. Redo names/offsets for 743/V

@github-actions
Copy link

github-actions bot commented Oct 2, 2021

Memory map comparison

@github-actions
Copy link

github-actions bot commented Oct 2, 2021

Memory map comparison

@github-actions
Copy link

github-actions bot commented Oct 2, 2021

Memory map comparison

@adamgreig
Copy link
Member

Thanks for this PR! I've updated it a bit to get cluster support too.

Getting clusters to work was a pain because of a few more weird inconsistencies (how on earth did they end up with FLT1CHGR when all the other FLTs are FLTxJCHGR???). In the end it seemed best to split it into separate files for 7B3, 743, and 735/47/53.

The downside is that the clusters do not form arrays because there is a gap between each cluster element, and svd2rust 0.19 cannot turn that into an array - it can't add padding because the padding might overlap over registers (though not in this case), and a recent PR to use an array proxy in this case hasn't been released yet (see rust-embedded/svd2rust#531 and rust-embedded/svd2rust#534).

Anyway, they are at least the same type, and in future will probably get arrayified.

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors bors bot merged commit 39d4255 into stm32-rs:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants