-
Notifications
You must be signed in to change notification settings - Fork 244
Fix address offsets on H743/V DFSDM #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like only the 743/743v use the names you've got in the file, the other H7 series use names either without the DFSDM prefix for the common registers like |
Done: Strip for non-H743. Redo names/offsets for 743/V |
Thanks for this PR! I've updated it a bit to get cluster support too. Getting clusters to work was a pain because of a few more weird inconsistencies (how on earth did they end up with The downside is that the clusters do not form arrays because there is a gap between each cluster element, and svd2rust 0.19 cannot turn that into an array - it can't add padding because the padding might overlap over registers (though not in this case), and a recent PR to use an array proxy in this case hasn't been released yet (see rust-embedded/svd2rust#531 and rust-embedded/svd2rust#534). Anyway, they are at least the same type, and in future will probably get arrayified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Addresses #636