Skip to content

Add missing DSI interrupt number for Stm32h747cm4 and Stm32h747cm7 #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Add missing DSI interrupt number for Stm32h747cm4 and Stm32h747cm7 #646

merged 1 commit into from
Oct 27, 2021

Conversation

LeonSkoog
Copy link
Contributor

According to RM0399: DSI interrupt should have number 123.

This PR addresses #645 issue.

@github-actions
Copy link

Memory map comparison

@adamgreig
Copy link
Member

adamgreig commented Oct 27, 2021

Thanks for the PR! Your change looks right for the H747 but it's also affecting the H7B3 and H735 files (RM0455 and RM0468) which don't seem to have a DSI interrupt (their NVIC tables have a blank for position 123). Could you move the patch to the stm32h747cm4.yaml and stm32h747cm7.yaml files directly, or perhaps create a new common_patches/h7_dsi_interrupt.yaml file, so we can target just the H747/RM0399 devices?

Hah, nevermind, I saw #648 which also fixes this.

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

bors merge

@bors bors bot merged commit d5d4465 into stm32-rs:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants