Memory map comparison

Thanks for this PR! Your changes look good, but we try to keep structural changes like the offset and field width to files in devices/ (and especially devices/common_patches/ for files that affect multiple devices), keeping peripherals/ just for enumerations.

Would you mind moving the two patches into suitable files in devices/? Thanks!

Memory map comparison

@adamgreig Are these acceptable locations? It seemed that there were some in peripheral subfolders but the bulk just in the root devices/common-patches folder.

There may be more consequences to the name change made I made in this commit for H7{4,5}3v - this fixes the generation of the web pages (makehtml.py) which otherwise could randomly pick h743 or h743v for the h743 entry since the name in the SVD file was identical where is should instead have a line item for all four H7{4,5}3{none, v}

SYSCFG:
  PWRCR:
    ODEN:
      Disabled: [0, "Overdrive mode disabled"]
      Enabled: [1, "Overdrive mode enabled (the LDO generates VOS0 for VCORE)"]

This is a human-readable enumeration, so it lives in peripherals/

SYSCFG:
  PWRCR:
    _modify:
      ODEN:
        bitWidth: 1
        description: "Overdrive enable"

This changes the register layout, so lives in devices/

You should be able to leave the existing syscfg_h747.yaml alone, and just add common_patches/h74x_syscfg_pwrcr.yaml as a new file.

For the BDMADR patch, devices/common_patches/h743_hrtim_common.yaml is good already!

Memory map comparison

SYSCFG:
  PWRCR:
    ODEN:
      Disabled: [0, "Overdrive mode disabled"]
      Enabled: [1, "Overdrive mode enabled (the LDO generates VOS0 for VCORE)"]

This is a human-readable enumeration, so it lives in peripherals/

SYSCFG:
  PWRCR:
    _modify:
      ODEN:
        bitWidth: 1
        description: "Overdrive enable"

This changes the register layout, so lives in devices/

You should be able to leave the existing syscfg_h747.yaml alone, and just add common_patches/h74x_syscfg_pwrcr.yaml as a new file.

For the BDMADR patch, devices/common_patches/h743_hrtim_common.yaml is good already!

Should be fixed. :) Let me know if there is anything else you would like changed.

Looks good, thanks! Do you know the reason for adding the modify name: STM32H753v on the stm32h753v SVD? Since that 'v' isn't officially in the part number (it was a bit of a hack to track the chip revision..), I'd say we should just leave the current name of STM32H753

Looks good, thanks! Do you know the reason for adding the modify name: STM32H753v on the stm32h753v SVD? Since that 'v' isn't officially in the part number (it was a bit of a hack to track the chip revision..), I'd say we should just leave the current name of STM32H753

The reason for adding the -V suffix fixes a separate problem where the website (https://stm32-rs.github.io/stm32-rs/) doesn't disambiguate the H743 and H743v so only presents the H743 svd and documentation status. I'm open to any solution to this problem, but this seemed the simplest to me due to the way the scripts currently work.

@richardeoin

Understood about changing the name to fix the website, but I would prefer to do that in a separate PR. If you can keep the name the same for this PR I can get it merged

Understood about changing the name to fix the website, but I would prefer to do that in a separate PR. If you can keep the name the same for this PR I can get it merged

Fixed

Memory map comparison

bors r+

👎 Rejected by too few approved reviews

Build succeeded:

• Check (stm32f0)
• Check (stm32f1)
• Check (stm32f2)
• Check (stm32f3)
• Check (stm32f4)
• Check (stm32f7)
• Check (stm32g0)
• Check (stm32g4)
• Check (stm32h7)
• Check (stm32l0)
• Check (stm32l1)
• Check (stm32l4)
• Check (stm32l5)
• Check (stm32mp1)
• Check (stm32wb)
• Check (stm32wl)