Skip to content

bump svd2rust to 0.20 #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2021
Merged

bump svd2rust to 0.20 #676

merged 1 commit into from
Dec 8, 2021

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Dec 7, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Memory map comparison

newAM
newAM requested changes Dec 7, 2021
View reviewed changes
Copy link
Member

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README needs to be updated for the new version

@burrbull
Copy link
Member Author

burrbull commented Dec 7, 2021

README needs to be updated for the new version

It is not new version. It is dependency.

@newAM
Copy link
Member

newAM commented Dec 7, 2021 •
edited
Loading

Sorry, I should be more clear, I mean the version in the "building locally" instructions in the README:

stm32-rs/README.md

Line 93 in a2b0072

* Install `svd2rust`: `cargo install --version 0.19.0 svd2rust`

@burrbull
Copy link
Member Author

burrbull commented Dec 7, 2021

Sorry, I should be more clear, I mean the version in the "building locally" instructions in the README:

stm32-rs/README.md

Line 93 in a2b0072

* Install `svd2rust`: `cargo install --version 0.19.0 svd2rust`

Fixed. Thanks

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Memory map comparison

@burrbull
Copy link
Member Author

burrbull commented Dec 8, 2021

bors r=newAM

@bors
Copy link
Contributor

bors bot commented Dec 8, 2021

🔒 Permission denied

Existing reviewers: click here to make burrbull a reviewer

adamgreig
adamgreig approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 8, 2021

Build succeeded:

@bors bors bot merged commit 4a70124 into stm32-rs:master Dec 8, 2021
@burrbull burrbull deleted the svd2rust020 branch August 14, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

@newAM newAM newAM approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burrbull @newAM @adamgreig