F301: Add missing P to JADST #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The f301 is the only device in the F3 family, which has the field name wrong. In the datasheet [RM0366] 12.5.3 `JADSTP` is also used. [RM0366]: https://www.st.com/resource/en/reference_manual/dm00094350.pdf
Only the peripheral is named ADC_Common. ADC1_2 is consistently used for every F3 family device except F3x4 (and F373, which has no common ADC). The address is the same compared to the other devices and in other places ADC12 is already used for some fields and descriptions
richardeoin
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Thanks, looks good.
In case anyone missed it, the reason for the peripheral rename is in the commit message
Only the peripheral is named ADC_Common. ADC1_2 is consistently used for
every F3 family device except F3x4 (and F373, which has no common ADC).The address is the same compared to the other devices and in other
places ADC12 is already used for some fields and descriptions
bors r+
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The f301 is the only device in the F3 family, which has the field name
wrong. In the datasheet RM0366 12.5.3
JADSTPis also used.