Adds DCMI/PSSI peripheral and adds DCMI/PSSI support to H735 #766
+367
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardeoin
reviewed
Aug 20, 2022
There was a problem hiding this comment.
Thanks for the PR! I haven't reviewed fully but made a few comments inline.
There's a rough rule for managing the repository that changes to the register structure (for example bit offsets, adding new fields/registers) should go in a file under devices/common_patches/. So in fact the register definitions should go there, separately from the enumerated values.
… blocks Fixes bit offsets for DEPOL and CKPOL (thanks to @richardeoin) Moves modify blocks to common_patches to adhere to repository standards (thanks to @richardeoin)
|
Thank you very much @richardeoin for the review. I have fixed the bit offsets and moved the modify blocks to the common_patches directory. |
|
DCMI/PSSI is already added for L4+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for the DCMI and PSSI peripherals.
So far I know of at least the H735 and L4+ series that support these peripherals.
As a starting point the peripherals have been added to the H735 series but are also available in other SVDs. Happy to add them to those if required - but I don't have experience with those devices so didn't want to add them initially.
Remarks:
Additional Devices where DCMI is available in the SVDs: