Fdcan fixes #796
Draft
Fdcan fixes #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willcrozi
commented
Jan 28, 2023
46819b9 to
a116ef4
Compare
|
Please, rebase on master branch. Is this ready to review? |
|
Sure, I'll take some time to refamiliarise myself with the project and go over the conflicts with master. It's been a while! |
|
I think this is ready to start reviewing. I'm thinking to do changelog once we know the final contents for merging. A couple of points:
|
Instead of deriving FDCAN2 from FDCAN1 (resulting in redundant TTCAN registers), create a new base peripheral without TTCAN registers. Also fixes incorrect FDCAN interrupts on H72x/H73x
|
Looking through this some more I can see it still needs work, marking as draft for now |
|
stm32h7 archive was updated to last version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my attempt at fixing some FDCAN related issues, primarily I was interested in H735 but as I worked on this I realised the fixes applied to multiple devices.
FDCAN: new base peripheral for non-TTCAN FDCAN peripherals
This gets rid of the derived FDCAN2 (SVD has lots of TTCAN registers in FDCAN2 that don't exist in hardware). Instead it copies FDCAN1 and deletes the TTCAN registers. Due to the inconsistent naming for FDCAN1 (aka TT_CAN in some SVDs) and restrictions from the way YAML patches get applied, I've needed to change/add some files in
common_patches/. Hopefully it makes sense.H735: add missing FDCAN3 peripheral
This derives from FDCAN2 to add a third FDCAN peripheral for H735
MP1: update reference manual URLs
Thrown in here to avoid a separate pull request
H7B3: fix FDCAN CCU registers
H7B3 SVD has loads of TTCAN registers instead of the correct CCU ones, so this just removes them all and adds the correct ones back. The patch is based on H735 patched SVD and checked against reference manual with a couple of errors fixed. It may be worth applying this to all devices with a CAN CCU (at least H7xx and MP1xx seem to have identical CCUs).
Feedback appreciated!