Skip to content

check CARGO_HOME env var #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

check CARGO_HOME env var #850

wants to merge 8 commits into from

Conversation

eZioPan
Copy link
Contributor

@eZioPan eZioPan commented Jun 10, 2023

check CARGO_HOME env var before put binary into default place

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@eZioPan eZioPan changed the title check CARGO_HOME env var check CARGO_HOME env var Jun 10, 2023
@eZioPan
Copy link
Contributor Author

eZioPan commented Jun 10, 2023

Are my changes conflict with CI workflow? The script runs fine on my linux machine.

@github-actions
Copy link

Memory map comparison

@eZioPan eZioPan force-pushed the check-CARGO_HOME branch from 12af2cd to e2f9b67 Compare June 10, 2023 03:16
@eZioPan eZioPan changed the title check CARGO_HOME env var [HelpNeeded]check CARGO_HOME env var Jun 10, 2023
@adamgreig
Copy link
Member

The CI failure is in the alternative cargo-make based Makefile.toml rather than the regular Makefile. I guess it's somehow ending up installing the tools to a directory that's not on PATH or something like that... if you run cargo make locally does it work out?

@eZioPan
Copy link
Contributor Author

eZioPan commented Jun 12, 2023

cargo make run smoothly on my local linux machine. The only en vars I add is RUSTUP_HOME and CARGO_HOME.

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@eZioPan
Copy link
Contributor Author

eZioPan commented Jun 12, 2023

it's weird, in CI, PATH env inlude ${CARGO_HOME}/bin/ https://github.com/stm32-rs/stm32-rs/actions/runs/5239385480/jobs/9459159924

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Memory map comparison

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Memory map comparison

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Memory map comparison

@eZioPan eZioPan changed the title [HelpNeeded]check CARGO_HOME env var check CARGO_HOME env var Aug 1, 2023
@eZioPan
Copy link
Contributor Author

eZioPan commented Aug 1, 2023

@adamgreig sorry for take that long time to fix the bug. I would ask a review on this again.

@eZioPan eZioPan mentioned this pull request Aug 1, 2023
Draft
@eZioPan
Copy link
Contributor Author

eZioPan commented Aug 1, 2023 •
edited
Loading

Modification included in PR #865
Closed.

@eZioPan eZioPan closed this Aug 2, 2023
@eZioPan eZioPan deleted the check-CARGO_HOME branch January 12, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eZioPan @adamgreig