Skip to content

Fix the rt feature for stm32h7 0.14.0 #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2021
Merged

Fix the rt feature for stm32h7 0.14.0 #287

merged 2 commits into from
Dec 4, 2021

Conversation

newAM
Copy link
Member

@newAM newAM commented Dec 4, 2021

The stm32h7 crate includes 'rt' as a default feature for 0.14.0: https://docs.rs/crate/stm32h7/0.14.0/source/Cargo.toml

@newAM
Fix the rt feature for stm32h7 0.14.0
382b9ce 
The stm32h7 crate includes 'rt' as a default feature for 0.14.0.
@richardeoin
Copy link
Member

Upstream change here: stm32-rs/stm32-rs#582

@richardeoin
Copy link
Member

richardeoin commented Dec 4, 2021 •
edited
Loading

I suggest we follow the same suggestion and make rt a default feature here also. All our CI builds include this feature, so a bit strange for it not to be default really

@newAM
Copy link
Member Author

newAM commented Dec 4, 2021

I suggest we follow the same suggestion and make rt a default feature here also. All our CI builds include this feature, so a bit strange for it not to be default really

Done! 👍

richardeoin
richardeoin approved these changes Dec 4, 2021
View reviewed changes
Copy link
Member

@richardeoin richardeoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 4, 2021

Build succeeded:

@bors bors bot merged commit 40f9b60 into stm32-rs:master Dec 4, 2021
@newAM newAM deleted the fix-rt-feature branch December 4, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardeoin richardeoin richardeoin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newAM @richardeoin