Skip to content

Release 0.8.1 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Release 0.8.1 #205

wants to merge 2 commits into from

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Dec 9, 2021

This also adds a RELEASING.md file as internal documentation.

@dbrgn dbrgn added the chore label Dec 9, 2021
@dbrgn dbrgn requested a review from hannobraun December 9, 2021 14:00
@dbrgn dbrgn self-assigned this Dec 9, 2021
@dbrgn dbrgn requested a review from a team as a code owner December 9, 2021 14:00

### Breaking Changes

- Setup hsi16diven when running Rcc::freeze ([#197])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking because it changes public API.


### Additions

- Unify RCC enable / reset ([#196])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is an addition or breaking / non-breaking change.

@dbrgn
Copy link
Contributor Author

dbrgn commented Dec 9, 2021

Note: Some changes are technically breaking changes, although it's highly unlikely that people are going to be affected. According to SemVer, below 0.x everything goes, so this would be acceptable from a spec point of view.

However, I could also change the version number to 0.9.0 instead.

@jamwaffles
Copy link
Contributor

IMO I think it's ok to release as 0.8.1 - this crate gets few downloads on crates.io. If upgrading to the latest stm32l0xx crate (waiting on stm32-rs/stm32-rs#659 to be released) is also a breaking change, that might be a good point to release 0.9.0?

@hannobraun
Copy link
Contributor

According to SemVer, below 0.x everything goes, so this would be acceptable from a spec point of view.

I think what's more relevant to us, is how Cargo implements SemVer. And Cargo treats 0.8.1 as compatible to 0.8.0.

I don't see a reason to cut corners here. Just call it 0.9.0. If we want to release 0.10.0 in 2 weeks, so be it.

@dbrgn
Copy link
Contributor Author

dbrgn commented Dec 9, 2021

I'm sure people will have lockfiles in their firmware projects. Nevertheless, it doesn't hurt to bump to 0.9, we could also release 0.137 next week and it would still be OK 🙂

I'll create a replacement PR.

@dbrgn dbrgn closed this Dec 9, 2021
@dbrgn dbrgn mentioned this pull request Dec 9, 2021
@dbrgn
Copy link
Contributor Author

dbrgn commented Dec 9, 2021

-> #207

@dbrgn dbrgn deleted the release-0.8.1 branch December 9, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants