Skip to content

F412RE: Issues with TIM6_DAC_IRQn in timer.h #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
InternetAthiest opened this issue Oct 29, 2019 · 4 comments · Fixed by #740
Closed

F412RE: Issues with TIM6_DAC_IRQn in timer.h #739

InternetAthiest opened this issue Oct 29, 2019 · 4 comments · Fixed by #740
Assignees
@fpistm
Labels
bug 🐛 Something isn't working
Milestone
1.8.0🎄 🎅

Comments

@InternetAthiest
Copy link

InternetAthiest commented Oct 29, 2019 •
edited
Loading

Created a custom variant of a F412RET6 and kept getting compiler errors. Apperently timer.h assumes that all but L1 and F1 series has a DAC (see row 61-69 in timer.h) which is not correct. Maybe add a check for those certain models or maybe check if HAL_DAC_MODULE_ENABLED is defined?
@fpistm
Copy link
Member

fpistm commented Oct 30, 2019

Hi @InternetAthiest
Could you share your variant, please?
HAL_DAC_MODULE_ENABLED is not the right thing to check. You can have DAC and module disabled.

fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Oct 30, 2019
@fpistm
Fix TIM6_IRQn definition
a05e2e8 
If no DAC then TIM6_IRQn is already defined.
Fixes stm32duino#739

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm self-assigned this Oct 30, 2019
@fpistm fpistm added the bug 🐛 Something isn't working label Oct 30, 2019
@fpistm fpistm added this to the 1.8.0 milestone Oct 30, 2019
@fpistm fpistm mentioned this issue Oct 30, 2019
Merged
@fpistm
Copy link
Member

fpistm commented Oct 30, 2019

@InternetAthiest
Could you test #740
Thanks in advance

@InternetAthiest
Copy link
Author

InternetAthiest commented Oct 30, 2019 •
edited
Loading

@fpistm
#740 fixed it, works wonders now!
Thanks!

@fpistm
Copy link
Member

fpistm commented Oct 30, 2019

welcome

fpistm added a commit that referenced this issue Oct 30, 2019
@fpistm
Fix TIM6_IRQn definition
5d32e51 
If no DAC then TIM6_IRQn is already defined.
Fixes #739

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fpistm fpistm

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
1.8.0🎄 🎅
Development

Successfully merging a pull request may close this issue.

Fix TIM6_IRQn definition fpistm/Arduino_Core_STM32
2 participants
@InternetAthiest @fpistm