Skip to content

Add composite MSC CDC USB device (follow up to PR #586) #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add composite MSC CDC USB device (follow up to PR #586) #1004

wants to merge 2 commits into from

Conversation

Bob-the-Kuhn
Copy link

This is a follow up to PR #586. The design is the same but now uses the latest middle wares.

Please see PR #586 for details.

This should be considered experimental until others have had a chance to play with it.

This code was tested with two boards: Black STM32F407 and STEVAL

The Marlin sketch this was tested with is at PR 17222.

OPEN ITEMS:

  • General cleanup - I'm sure some of my comments to myself and test code weren't all purged.
  • Initialization sequence needs to be reviewed in detail. I may still have some redundant items in it. The switching to 4 bit wide mode routine may be redundant.
  • Look at a way to stay in 1 bit wide mode. I have a vague recollection of one board not connecting all the SDIO data lines.
  • The FIFO configuration needs more investigation. Currently I can only set the PCD FIFOs to the minimum needed length. Previously I was able to set FIFOs to use almost all the available space.
  • My 4G SD card doesn't work with this software. I need to root cause that.

@Bob-the-Kuhn Bob-the-Kuhn mentioned this pull request Mar 20, 2020
Merged
@fpistm
Copy link
Member

fpistm commented Mar 21, 2020

Hi @Bob-the-Kuhn
why not simply update the previous PR ?

I'm a little bit lost.

now uses the latest middle wares

What did you mean by this?

@Bob-the-Kuhn
Copy link
Author

why not simply update the previous PR ?

I was able to do this. I'm going to close this PR.

now uses the latest middle wares

Back in mid 2019 there was mention that the middle wares were going to be updated so I put this work aside. I had some free time earlier this year so I started this work back up assuming that the updates had been done.

@Bob-the-Kuhn Bob-the-Kuhn mentioned this pull request Mar 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bob-the-Kuhn @fpistm