Skip to content

enabling IPCC module of the stm32WB55 #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Conversation

FRASTM
Copy link
Contributor

@FRASTM FRASTM commented Sep 25, 2020

This PR is the introduction of the BLE for the stm32WB55

Requires stm32duino/STM32duinoBLE#17

@FRASTM FRASTM changed the title [WIP]enabling IPCC module of the stm32WB55 [WIP] enabling IPCC module of the stm32WB55 Sep 25, 2020
@fpistm fpistm marked this pull request as draft September 25, 2020 12:43
@FRASTM FRASTM force-pushed the w55_BLE branch 4 times, most recently from 8231175 to 5055463 Compare November 2, 2020 18:01
@fpistm fpistm self-requested a review November 9, 2020 07:59
@fpistm fpistm added the enhancement New feature or request label Nov 9, 2020
@fpistm fpistm assigned fpistm and unassigned fpistm Nov 9, 2020
@fpistm fpistm added this to the 2.0.0 milestone Nov 9, 2020
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my review comments, please:

  • Rebase and squash on top of the master and change commit message to something like:

[PNUCLEO_WB55RG] BLE support configuration

  • Enable IPCC HAL module
  • Manage OTP to ...
  • Update clock configuration
  • Apply astyle (script available in CI/astyle/astyle.py)

@FRASTM
Copy link
Contributor Author

FRASTM commented Nov 9, 2020

fix according to the review (mainly astyle)
squash in one commit

@FRASTM FRASTM force-pushed the w55_BLE branch 3 times, most recently from 81a28f7 to e7133bb Compare November 9, 2020 10:34
@fpistm fpistm marked this pull request as ready for review November 9, 2020 13:13
@FRASTM FRASTM force-pushed the w55_BLE branch 2 times, most recently from a17cf4e to c00f262 Compare November 10, 2020 08:05
@FRASTM FRASTM changed the title [WIP] enabling IPCC module of the stm32WB55 enabling IPCC module of the stm32WB55 Nov 10, 2020
Enable IPCC HAL module which transport the HCI command
over the Shared Mem.
Update clock configuration for BLE on this nucleo_wb55rg
Manage OTP to access the device bd address

Signed-off-by: Francois Ramu <francois.ramu@st.com>
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @FRASTM

@fpistm fpistm merged commit 6df682d into stm32duino:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants