Fix SPI memory leak #138
Merged
Fix SPI memory leak #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMESTM
reviewed
Oct 24, 2017
libraries/SPI/src/SPI.cpp
Outdated
| tmp = ((data & 0xff00) >> 8) | ((data & 0xff) << 8); | ||
| data = tmp; | ||
| uint8_t idx = pinIdx(_pin, GET_IDX); | ||
| if(idx == NB_SPI_SETTINGS) { |
There was a problem hiding this comment.
Maybe this would even be safer to check
if(idx >= NB_SPI_SETTINGS)
There was a problem hiding this comment.
So should be applied on all those same tests done in SPI.cpp
fpistm
reviewed
Oct 24, 2017
Signed-off-by: fpr <fabien.perroquin@wi6labs.com>
fpistm
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPI library patched to remove overrun of an array causing random behaviour.
There is no problem with UART layer.
The WiFi library is OK now.