Skip to content

Add SparkFun MicroMod STM32F405 #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Mar 31, 2023
Merged

Conversation

bsatrom
Copy link
Contributor

@bsatrom bsatrom commented Mar 29, 2023

Summary

Add support for the SparkFun MicroMod STM32F405

Validation

Tested locally with the CheckVariant sketch.

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bsatrom
thanks for your contribution.

bsatrom and others added 2 commits March 30, 2023 08:27
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
@fpistm fpistm added this to the 2.6.0 milestone Mar 30, 2023
@bsatrom bsatrom requested a review from fpistm March 30, 2023 13:58
bsatrom and others added 9 commits March 30, 2023 09:29
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
@bsatrom bsatrom requested a review from fpistm March 30, 2023 14:46
@bsatrom bsatrom requested a review from fpistm March 30, 2023 17:15
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After those required changes, I think it would be ok to merge.

bsatrom and others added 3 commits March 31, 2023 08:53
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
@bsatrom
Copy link
Contributor Author

bsatrom commented Mar 31, 2023

After those required changes, I think it would be ok to merge.

All done, thanks for being so quick to review @fpistm!

@fpistm
Copy link
Member

fpistm commented Mar 31, 2023

Welcome @bsatrom
Thanks for the quick update too 😉
LGTM, waiting CI status before merge. Of course I did not test the board as I do not have it.

@fpistm fpistm merged commit 2d21caa into stm32duino:main Mar 31, 2023
@bsatrom bsatrom deleted the sparkfun-micromod-f405 branch March 31, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants