Skip to content

PR #447 review #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2019
Merged

PR #447 review #473

merged 3 commits into from
Apr 3, 2019

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Mar 15, 2019 •
edited
Loading

This PR is based on #447

  • Rebase on top of the master
  • Squash several commit
  • Update commit message
  • Factorize some code
  • Fix typo
  • Reorder functions

Still Servo to review and maybe could be proposed as PR replacement of arduino-libraries/Servo#10

@fpistm fpistm mentioned this pull request Mar 15, 2019
Closed
@fpistm fpistm added New feature waiting feedback Further information is required labels Mar 18, 2019
Tjeerdie and others added 3 commits April 3, 2019 15:04
@Tjeerdie @fpistm
[Timer] Add channels support
0ad4b5a
@Tjeerdie @fpistm
[Timer] Add set prescaler register function
afe4d85 
Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
@fpistm
[Timer] Reorder functions
9fb6bcc 
Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
@fpistm fpistm removed the waiting feedback Further information is required label Apr 3, 2019
@fpistm
Copy link
Member Author

fpistm commented Apr 3, 2019 •
edited
Loading

Thanks @Tjeerdie
Note: I rebase it before merge to ensure no issue on top of the master.

@fpistm fpistm merged commit 64fb236 into stm32duino:master Apr 3, 2019
@fpistm fpistm deleted the pr-447-rework branch April 3, 2019 13:48
benwaffle pushed a commit to benwaffle/Arduino_Core_STM32 that referenced this pull request Apr 10, 2019
@fpistm
Merge pull request stm32duino#473 from fpistm/pr-447-rework
56df0e9 
PR stm32duino#447 review
This was referenced Apr 26, 2019
Closed
Closed
@fpistm fpistm added enhancement New feature or request and removed New feature labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tjeerdie Tjeerdie Tjeerdie approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpistm @Tjeerdie