Support custom Usb reenumerate #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
requested changes
Apr 16, 2019
There was a problem hiding this comment.
This file should not be in the PR:
cores/arduino/stm32/usb/usbd_if.h.gch
One note, it should be better to not pull/merge original master in your fork.
This bring lot of pollution in the PR. You can refers to the contributing guidelines.
Simply fetch origin then push fork master on original master align properly the master then you can easily rebase your branch.
|
I'll update it once I've done that, thanks. |
feb377e to
143a7b5
Compare
Remove unnecessary extern "C" declaration.
143a7b5 to
94079af
Compare
Co-Authored-By: xC0000005 <32139633+xC0000005@users.noreply.github.com>
fpistm
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features
making the renumerate function weak allows a variant to override it
Validation
Tested on Malyan M200 V1 rev 1, 3, and 4 (STM32F103) and on Malyan M200 V2 (STM32F070) to make sure it didn't affect others.