Skip to content

Support LAN8720 ETH BOARD #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support LAN8720 ETH BOARD #581

wants to merge 1 commit into from

Conversation

nopnop2002
Copy link

@nopnop2002 nopnop2002 commented Jul 28, 2019 •
edited
Loading

Support LAN8720 ETH BOARD

Please see here
stm32duino/STM32Ethernet#23

@nopnop2002 nopnop2002 changed the title Supprt LAN8720 ETH BOARD Support LAN8720 ETH BOARD Jul 28, 2019
@nopnop2002 nopnop2002 mentioned this pull request Jul 28, 2019
Closed
@fpistm
Copy link
Member

fpistm commented Jul 30, 2019

Hi @nopnop2002
thanks for this PR.
Anyway, I think this is not the right way to support this PHY (mainly due to use of the same name).
I think an update of the library will be better and will allow to support more PHY layer as requested here:
stm32duino/STM32Ethernet#15

I think the PHY configuration will have to be moved from the core to the library.

@fpistm fpistm closed this Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nopnop2002 @fpistm