Skip to content

Fix Java PATH problem on Windows (Fix Issue #67) #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dadul96
Copy link

@dadul96 dadul96 commented Aug 30, 2020

This solves the problem where this batch file may use a different Java version compared to the one provided by the Arduino IDE.
(see Issue #67)

This solves the problem where this batch file may use a different Java version compared to the one provided by the Arduino IDE.
Passes the Arduino IDE installation path to the batch file. (Requires a change in platform.txt)
@dadul96
Copy link
Author

dadul96 commented Dec 21, 2020

Update

This improved version of the fix enables passing the Arduino IDE installation path to the maple_upload.bat-file in order to always use the correct Java PATH regardless of the Arduino IDE location.
This PR only works in combination with the PR in "stm32duino/Arduino_Core_STM32": #1267.

Test/Verification

The whole fix has been verified by me and was also successfully merged into the Arduino_STM32-repository of Roger Clark. (See: merged PR)

@fpistm
Copy link
Member

fpistm commented Apr 15, 2021

I close this PR as it does not ensure not covered all possible case. Moreover it brings new issue see rogerclarkmelbourne/Arduino_STM32#846

@fpistm fpistm closed this Apr 15, 2021
@fpistm fpistm added the invalid This doesn't seem right label Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants