Skip to content

MassStorageCopy updated to manage several node names. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2017
Merged

MassStorageCopy updated to manage several node names. #8

merged 3 commits into from
Jun 20, 2017

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jun 16, 2017

Depending of the board revision, mount point name could be different.
Ex for: STM32F030R8 with a rev 1 node name is : "NUCLEO"
while it is "NODE_F030R8" for rev c

Ex: in boards.txt we could have:
Nucleo_64.menu.Nucleo_64_board.NUCLEO_F030R8.node="NODE_F030R8,NUCLEO"

Fix #6

Signed-off-by: Frederic Pillon frederic.pillon@st.com

@fpistm fpistm force-pushed the issue_6 branch 2 times, most recently from 2d677b4 to c01f5f2 Compare June 16, 2017 12:43
@fpistm
MassStorageCopy updated to manage several node names.
82eb13a 
Depending of the board revision, mount point name could be different.
Ex for: STM32F030R8 with a rev 1 node name is : "NUCLEO"
while it is "NODE_F030R8" for rev c

Ex: in boards.txt we could have:
Nucleo_64.menu.Nucleo_64_board.NUCLEO_F030R8.node="NODE_F030R8,NUCLEO"

Fix #6

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@RickKimball
Copy link

RickKimball commented Jun 16, 2017 •
edited
Loading

This seems to work for my board that uses NUCLEO as the volume label.

I did see some multiple warnings when I compiled:

gcc -m32 -c massStorageCopy.c
massStorageCopy.c: In function ‘main’:
massStorageCopy.c:69:18: warning: implicit declaration of function ‘isprint’ [-Wimplicit-function-declaration]
         else if (isprint (optopt))

You might want to add a #include <ctype.h> line

$ git diff
diff --git a/src/massStorageCopy/massStorageCopy.c b/src/massStorageCopy/massStorageCopy.c
index 6fd5acc..d3c7dfc 100644
--- a/src/massStorageCopy/massStorageCopy.c
+++ b/src/massStorageCopy/massStorageCopy.c
@@ -5,6 +5,7 @@
 #include <mntent.h>
 #include <unistd.h>
 #include <errno.h>
+#include <ctype.h>
 
 static char *input_path = NULL;
 static char *output_path = NULL;
$

@fpistm
Copy link
Member Author

fpistm commented Jun 16, 2017 •
edited
Loading

I will add it. I didn't have this warning on my OS.
I try to not release code with warning ^^

MassStorage updated to manage several node name on MacOSX. Source fil…
68b6a77 
…e modified to be as close as possible than Linux source. Easier to maintain.

Signed-off-by: fpr <fabien.perroquin@wi6labs.com>
@ghost
Copy link

ghost commented Jun 19, 2017

MassStorageCopy updated for MacOSX. Source file modified to be as close as Linux source file. It will be easier to maintain in the future.
Tested on El Capitan version 10.11.6.

@fpistm
Minor update to avoid warning
e82d0f2 
Fix typo

Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
@fpistm fpistm merged commit 5e8c676 into master Jun 20, 2017
@fpistm fpistm deleted the issue_6 branch August 21, 2017 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpistm @RickKimball