Skip to content

Add EthernetClient functions: localPort, remoteIP, remotePort #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2019
Merged

Add EthernetClient functions: localPort, remoteIP, remotePort #27

merged 1 commit into from
Oct 17, 2019

Conversation

gdsports
Copy link
Contributor

SSLClient needs these functions

@fpistm
Copy link
Member

fpistm commented Oct 17, 2019

Hi @gdsports,
Thanks for this PR a nd your work.

@fpistm fpistm self-requested a review October 17, 2019 05:40
@fpistm fpistm added the enhancement New feature or request label Oct 17, 2019
@fpistm fpistm added this to the 1.1.0 milestone Oct 17, 2019
@fpistm
Copy link
Member

fpistm commented Oct 17, 2019

Linked to #14 (comment)

To add support in https://github.com/OPEnSLab-OSU/SSLClient

fpistm
fpistm approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All types are correct.

@fpistm fpistm merged commit 75fefe6 into stm32duino:master Oct 17, 2019
@gdsports gdsports deleted the ssl branch October 26, 2019 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdsports @fpistm