Skip to content

Update Ethernet.linkStatus to handle Unknown status #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2019
Merged

Update Ethernet.linkStatus to handle Unknown status #31

merged 1 commit into from
Oct 28, 2019

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Oct 25, 2019

Hi @gdsports
could you review/test this PR please.
Thanks in advance

@fpistm
Update Ethernet.linkStatus to handle Unknown status
7a3dc99 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
gdsports
gdsports reviewed Oct 25, 2019
View reviewed changes
Copy link
Contributor

@gdsports gdsports left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. I tested by calling linkStatus before calling begin and received the Unknown status. After begin succeeds, linkStatus returns LinkON/LinkOff as expected. I see no problems.

@fpistm fpistm added the enhancement New feature or request label Oct 28, 2019
@fpistm fpistm added this to the 1.1.0 milestone Oct 28, 2019
@fpistm fpistm merged commit 5f6c5b6 into stm32duino:master Oct 28, 2019
@fpistm fpistm deleted the StatusUpdate branch October 28, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdsports gdsports gdsports left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fpistm @gdsports