Fix issue #3 and #4 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
reviewed
Oct 16, 2017
src/utility/stm32_eth.c
Outdated
| TimHandle.timer = DEFAULT_ETHERNET_TIMER; | ||
|
|
||
| /* Timer set to 1ms */ | ||
| TimerHandleInit(&TimHandle, (uint16_t)(1000 - 1), ((uint32_t)(getTimerClkFreq(TIM6) / (1000000)) - 1)); |
There was a problem hiding this comment.
Should be DEFAULT_ETHERNET_TIMER?
| static void TIM_scheduler_Config(void) | ||
| { | ||
| /* Set TIMx instance. */ | ||
| TimHandle.timer = DEFAULT_ETHERNET_TIMER; |
There was a problem hiding this comment.
Need to be defined in variant.h ?
There was a problem hiding this comment.
I defined it in lwipopt.h. I think it is better to keep all Ethernet options in this file.
|
If this PR is validated, the register callback could be removed indeed. |
|
please @fprwi6labs could you remove the register cb. |
|
Issue #4 fixed. Initialization sequence must be done only once. |
fpistm
approved these changes
Oct 20, 2017
added 2 commits
October 20, 2017 12:01
Signed-off-by: fpr <fabien.perroquin@wi6labs.com>
Signed-off-by: fpr <fabien.perroquin@wi6labs.com>
fpistm
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #3
To test this PR please add
#define DEFAULT_ETHERNET_TIMER TIM6in lwipopts.hThe issue #4 is also fixed:
begin()is called several time.