Skip to content

if DHCP fails the static IP can be applied without problem #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 11, 2022
Merged

if DHCP fails the static IP can be applied without problem #50

merged 7 commits into from
Mar 11, 2022

Conversation

Solairseir
Copy link
Contributor

when DHCP fails the static IP can be applied without problem
adding timeout to client connection

@fpistm fpistm requested a review from ABOSTM February 28, 2022 14:24
ABOSTM
ABOSTM reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless timeout to be removed, otherwise, LGTM

@fpistm fpistm added this to the 12.x milestone Mar 1, 2022
@fpistm fpistm added the enhancement New feature or request label Mar 1, 2022
@fpistm @ABOSTM
Update src/EthernetClient.cpp
2304530 
Co-authored-by: Alexandre Bourdiol <50730894+ABOSTM@users.noreply.github.com>
fpistm
fpistm requested changes Mar 11, 2022
View reviewed changes
@fpistm fpistm merged commit d5993db into stm32duino:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABOSTM ABOSTM ABOSTM left review comments

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Solairseir @fpistm @ABOSTM