Skip to content

feat: Add function to define port of EthernetServer at runtime #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2022
Merged

feat: Add function to define port of EthernetServer at runtime #63

merged 1 commit into from
Apr 26, 2022

Conversation

patricklaf
Copy link
Contributor

I use the EthernetServer class but I must read the port to be used from a configuration file on an SD Card at runtime.
As the port is optionally defined in the constructor and only used in the begin() function, I added a begin(uint16_t port) function to set port if needed,

@fpistm fpistm requested a review from ABOSTM April 25, 2022 15:38
ABOSTM
ABOSTM approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patricklaf ,
Thanks for this PR.
LGTM

@fpistm fpistm added the enhancement New feature or request label Apr 26, 2022
@fpistm fpistm added this to the 1.2.x milestone Apr 26, 2022
@fpistm fpistm merged commit 89e4523 into stm32duino:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABOSTM ABOSTM ABOSTM approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@patricklaf @ABOSTM @fpistm