Skip to content

Fix LowPower Sleep Mode #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2022
Merged

Fix LowPower Sleep Mode #74

merged 2 commits into from
Aug 23, 2022

Conversation

ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Aug 5, 2022 •
edited
Loading

Fix LowPower Sleep Mode:

  • fix: restore Main regulator on LowPower Sleep exit
  • fix: in case of LowPower Sleep, it is necessary to decrease CPU Frequency

Fixes #73

@ABOSTM ABOSTM added the bug label Aug 5, 2022
@ABOSTM ABOSTM requested a review from fpistm August 5, 2022 16:54
@ABOSTM ABOSTM mentioned this pull request Aug 5, 2022
Closed
@ABOSTM
Copy link
Contributor Author

ABOSTM commented Aug 5, 2022

Currently tested only on L4.
Waiting CI on other STM32 series

@tshcherban
Copy link
Contributor

@ABOSTM can verify on STM32L051C8T6
can you give some details what should i check?

ABOSTM added 2 commits August 23, 2022 15:09
@ABOSTM
fix: restore Main regulator on LowPower Sleep exit
6ebd123 
In case of LowPower Regulator used for sleep,
restore Main regulator on exit

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
@ABOSTM
fix: in case of LowPower Sleep, it is necessary to decrease CPU Frequ…
afc292f 
…ency

Decrease CPU freq before setting LPR mode,
Restore CPU freq after wakeup.

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
@ABOSTM
Copy link
Contributor Author

ABOSTM commented Aug 23, 2022

Tested on all STM32 series, with ExternalWakeup example,
working fine.

fpistm
fpistm approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm added this to the 1.2.1/1.3.0 milestone Aug 23, 2022
@fpistm fpistm merged commit 3023ea6 into stm32duino:main Aug 23, 2022
@ABOSTM ABOSTM mentioned this pull request Sep 7, 2022
Closed
@fpistm fpistm added fix 🩹 Bug fix and removed bug labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
fix 🩹 Bug fix
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

stm32l412kb nucleo not waking up from sleep mode.
3 participants
@ABOSTM @tshcherban @fpistm