Skip to content

fix(ExternalWakeup): customization may be needed depending on button implementation #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2022
Merged

fix(ExternalWakeup): customization may be needed depending on button implementation #78

merged 1 commit into from
Aug 23, 2022

Conversation

ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Aug 23, 2022

fix(ExternalWakeup): customization may be needed depending on button implementation

Warning: depending on boards, and its button hardware implementation,
it may be required to adapt INPUT_PULLUP/INPUT_PULLDOWN parameter
in pinMode(pin, XXX)

@ABOSTM
fix(ExternalWakeup): customization may be needed depending on button …
4d6f6ba 
…implementation

Warning: depending on boards, and its button hardware implementation,
it may be required to adapt INPUT_PULLUP/INPUT_PULLDOWN parameter
in pinMode(pin, XXX)

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
@ABOSTM ABOSTM requested a review from fpistm August 23, 2022 16:05
fpistm
fpistm approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm added the enhancement New feature or request label Aug 23, 2022
@fpistm fpistm added this to the 1.2.1/1.3.0 milestone Aug 23, 2022
@fpistm fpistm merged commit 1a17d41 into stm32duino:main Aug 23, 2022
@ABOSTM ABOSTM mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ABOSTM @fpistm