fix: ability to set alarm after reset #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You meant that #82? |
Be sure to set default value for alarmday, and thus avoid IS_RTC_DATE(day) being false when is not usd in alarm setting Take into account Reset usecase (being able to set new alarma after a reset) Factorize change of RTC clock source in the RTC_begin() function which imply a reset of BackupDomain. Save configuration before this BackupDomain reset, and restore after. fixes stm32duino#82 Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
92a1c5d to
c2700eb
Compare
yes |
fpistm
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: ability to set alarm after reset
Be sure to set default value for alarmday,
and thus avoid IS_RTC_DATE(day) being false
when is not usd in alarm setting
Take into account Reset usecase
(being able to set new alarma after a reset)
Factorize change of RTC clock source in the RTC_begin() function which imply a reset of BackupDomain.
Save configuration before this BackupDomain reset, and restore after.
Tested with sketches from RTC and LowPower libraries,
on both Nucleo F103RB and Nucleo L476RG
fixes stm32duino/STM32LowPower#82