-
Notifications
You must be signed in to change notification settings - Fork 335
feat: claude citation support with BedrockModel #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unshure
reviewed
Aug 11, 2025
Co-authored-by: Nick Clegg <nac542@gmail.com>
* removes client exception handling * moves citation into text elif * puts relative imports back
Unshure
requested changes
Aug 20, 2025
Removes old comment Co-authored-by: Nick Clegg <nac542@gmail.com>
Removes old comment Co-authored-by: Nick Clegg <nac542@gmail.com>
Refactor imports in bedrock.py to include CitationsDelta.
Unshure
approved these changes
Aug 28, 2025
dbschmigelski
pushed a commit
to dbavro19/sdk-python
that referenced
this pull request
Aug 28, 2025
* feat: add citations to document content * feat: addes citation types * chore: remove uv.lock * test: add letter.pdf for test-integ * feat: working bedrock citations feature * feat: fail early for citations with incompatible models * fix: validates model ids with cross region inference ids * Apply suggestion from @Unshure Co-authored-by: Nick Clegg <nac542@gmail.com> * fix: addresses comments * removes client exception handling * moves citation into text elif * puts relative imports back * fix: tests failing * Update src/strands/models/bedrock.py Removes old comment Co-authored-by: Nick Clegg <nac542@gmail.com> * Update src/strands/models/bedrock.py Removes old comment Co-authored-by: Nick Clegg <nac542@gmail.com> * Update imports in bedrock.py Refactor imports in bedrock.py to include CitationsDelta. * feat: typed citation events --------- Co-authored-by: Nick Clegg <nac542@gmail.com>
Ratish1
pushed a commit
to Ratish1/sdk-python
that referenced
this pull request
Aug 30, 2025
* feat: add citations to document content * feat: addes citation types * chore: remove uv.lock * test: add letter.pdf for test-integ * feat: working bedrock citations feature * feat: fail early for citations with incompatible models * fix: validates model ids with cross region inference ids * Apply suggestion from @Unshure Co-authored-by: Nick Clegg <nac542@gmail.com> * fix: addresses comments * removes client exception handling * moves citation into text elif * puts relative imports back * fix: tests failing * Update src/strands/models/bedrock.py Removes old comment Co-authored-by: Nick Clegg <nac542@gmail.com> * Update src/strands/models/bedrock.py Removes old comment Co-authored-by: Nick Clegg <nac542@gmail.com> * Update imports in bedrock.py Refactor imports in bedrock.py to include CitationsDelta. * feat: typed citation events --------- Co-authored-by: Nick Clegg <nac542@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for citations when using Anthropic Claude Sonnet 3.5v2 and above
Related Issues
#570
Documentation PR
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.