Skip to content

Conversation

theagenticguy
Copy link
Collaborator

@theagenticguy theagenticguy commented Aug 7, 2025

Description

Adds support for citations when using Anthropic Claude Sonnet 3.5v2 and above

Related Issues

#570

Documentation PR

Type of Change

New feature

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@theagenticguy theagenticguy marked this pull request as ready for review August 8, 2025 21:49
@theagenticguy theagenticguy changed the title Claude citations feat: claude citation support with BedrockModel Aug 8, 2025
@zastrowm zastrowm added the area-provider Related to model providers label Aug 11, 2025
Co-authored-by: Nick Clegg <nac542@gmail.com>
* removes client exception handling
* moves citation into text elif
* puts relative imports back
@theagenticguy theagenticguy requested a review from Unshure August 18, 2025 22:41
Removes old comment

Co-authored-by: Nick Clegg <nac542@gmail.com>
Removes old comment

Co-authored-by: Nick Clegg <nac542@gmail.com>
Refactor imports in bedrock.py to include CitationsDelta.
@Unshure Unshure merged commit 47faba0 into strands-agents:main Aug 28, 2025
13 of 16 checks passed
dbschmigelski pushed a commit to dbavro19/sdk-python that referenced this pull request Aug 28, 2025
* feat: add citations to document content

* feat: addes citation types

* chore: remove uv.lock

* test: add letter.pdf for test-integ

* feat: working bedrock citations feature

* feat: fail early for citations with incompatible models

* fix: validates model ids with cross region inference ids

* Apply suggestion from @Unshure

Co-authored-by: Nick Clegg <nac542@gmail.com>

* fix: addresses comments

* removes client exception handling
* moves citation into text elif
* puts relative imports back

* fix: tests failing

* Update src/strands/models/bedrock.py

Removes old comment

Co-authored-by: Nick Clegg <nac542@gmail.com>

* Update src/strands/models/bedrock.py

Removes old comment

Co-authored-by: Nick Clegg <nac542@gmail.com>

* Update imports in bedrock.py

Refactor imports in bedrock.py to include CitationsDelta.

* feat: typed citation events

---------

Co-authored-by: Nick Clegg <nac542@gmail.com>
Ratish1 pushed a commit to Ratish1/sdk-python that referenced this pull request Aug 30, 2025
* feat: add citations to document content

* feat: addes citation types

* chore: remove uv.lock

* test: add letter.pdf for test-integ

* feat: working bedrock citations feature

* feat: fail early for citations with incompatible models

* fix: validates model ids with cross region inference ids

* Apply suggestion from @Unshure

Co-authored-by: Nick Clegg <nac542@gmail.com>

* fix: addresses comments

* removes client exception handling
* moves citation into text elif
* puts relative imports back

* fix: tests failing

* Update src/strands/models/bedrock.py

Removes old comment

Co-authored-by: Nick Clegg <nac542@gmail.com>

* Update src/strands/models/bedrock.py

Removes old comment

Co-authored-by: Nick Clegg <nac542@gmail.com>

* Update imports in bedrock.py

Refactor imports in bedrock.py to include CitationsDelta.

* feat: typed citation events

---------

Co-authored-by: Nick Clegg <nac542@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-provider Related to model providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants