Skip to content

feat: added final unit tests #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nmashchenko
Copy link
Contributor

Hey guys! This is my wrapping PR for component unit testing as I promised before.

I fixed all items you had problems with (as mentioned in #517):

  1. CustomError, ServerError, InternalError were requiring children even though you had a check children || "alt text" in there which didn't make sense and test exposed that (also fixed the issue)
  2. You almost don't use alt property on images, most of my tests exposed that but I decided to not change it for now, if you want me to I am happy to open separate prs to fix that!
  3. Most of your html input/labels dont have htmlFor and id for input/label pair, I can also open additional prs to fix that to enhance the repo

I also added final tests to all components to make sure they are functioning correctly and moving forward if there will be any changes you will be able to catch any issues in advance!

Signed-off-by: Nikita Mashchenko <mashchenko1@icloud.com>
@nmashchenko nmashchenko changed the title feat: added final component tests feat: added final unit tests Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants