Skip to content

Update add_beta_version logic #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 28, 2025
Merged

Conversation

mbroshi-stripe
Copy link
Contributor

@mbroshi-stripe mbroshi-stripe commented Mar 27, 2025

Why?

We decided to allow add_beta_version to overwrite an existing beta version

What?

  • Validates that beta_version is of the form "v" + a number
  • Allows overwriting existing beta_name. The new behavior is that the higher beta_version is accepted instead of raising an Exception.

Changelog

  • stripe.add_beta_version will use the highest version number used for a beta feature instead of raising an Exception on a conflict as it had done previously.

@mbroshi-stripe mbroshi-stripe requested a review from a team as a code owner March 27, 2025 15:43
@mbroshi-stripe mbroshi-stripe requested review from jar-stripe and helenye-stripe and removed request for a team and jar-stripe March 27, 2025 15:43
@mbroshi-stripe mbroshi-stripe merged commit 171d620 into beta Mar 28, 2025
15 checks passed
@mbroshi-stripe mbroshi-stripe deleted the mbroshi/update-add-beta-version branch March 28, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants