Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We've been having CI failures (such as this) because we're using a deprecated approach to building python packages (calling
python setup.py
) and trying to target a deprecated format (eggs). Rather than figure out exactly what broke, I've swapped us to using build, the current industry standard in favor ofsetuptools
.Separately, I added better logging to our dependency installation when running in CI, which will help us understand better why something might have broken.
Note: this has no user-facing impact. We're just building our package for distribution in a more modern way.
What?
python setup.py
call topython -m build
setuptools
dependency forbuild
See Also