Skip to content

switch build systems #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

switch build systems #1494

merged 1 commit into from
Apr 9, 2025

Conversation

xavdid-stripe
Copy link
Member

@xavdid-stripe xavdid-stripe commented Apr 8, 2025

Why?

We've been having CI failures (such as this) because we're using a deprecated approach to building python packages (calling python setup.py) and trying to target a deprecated format (eggs). Rather than figure out exactly what broke, I've swapped us to using build, the current industry standard in favor of setuptools.

Separately, I added better logging to our dependency installation when running in CI, which will help us understand better why something might have broken.

Note: this has no user-facing impact. We're just building our package for distribution in a more modern way.

What?

  • swap python setup.py call to python -m build
  • swap setuptools dependency for build
  • add more logging to dependency installation when running in CI.

See Also

@xavdid-stripe xavdid-stripe requested a review from a team as a code owner April 8, 2025 23:13
@xavdid-stripe xavdid-stripe requested review from jar-stripe and removed request for a team April 8, 2025 23:13
@xavdid-stripe xavdid-stripe enabled auto-merge (squash) April 8, 2025 23:19
Copy link
Contributor

@jar-stripe jar-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All for more reliable builds!

@xavdid-stripe xavdid-stripe merged commit 7219f8c into master Apr 9, 2025
14 checks passed
@xavdid-stripe xavdid-stripe deleted the pin-build-deps branch April 9, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants