Skip to content

Encode bools with lower case #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

Conversation

mbroshi-stripe
Copy link
Contributor

@mbroshi-stripe mbroshi-stripe commented Apr 18, 2025

Why?

We discovered that in V2, the Stripe API is more strict on boolean query parameters, and True/False are no longer accepted as boolean values, rather instead they need to be true/false. This will cause V2 Python SDK requests with boolean values to fail.

What?

  • Sets boolean query parameter values to true/false before sending to the Stripe API.

Changelog

  • Serializes boolean query parameter values to true/false (lower case) before sending to the Stripe API for compatibility with Stripe V2 endpoints

@mbroshi-stripe mbroshi-stripe requested a review from a team as a code owner April 18, 2025 20:18
@mbroshi-stripe mbroshi-stripe requested review from jar-stripe and removed request for a team April 18, 2025 20:18
Copy link
Contributor

@jar-stripe jar-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@mbroshi-stripe mbroshi-stripe merged commit 907a985 into master Apr 18, 2025
14 checks passed
@mbroshi-stripe mbroshi-stripe deleted the mbroshi/fix-python-bools branch April 18, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants