Skip to content

Added import for the new deprecated services in stripe_client #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

prathmesh-stripe
Copy link
Contributor

Why?

Need to add import deprecated decorator manually.

See Also

@prathmesh-stripe prathmesh-stripe requested a review from a team as a code owner June 5, 2025 17:02
@prathmesh-stripe prathmesh-stripe requested review from jar-stripe and removed request for a team June 5, 2025 17:02
Copy link
Contributor

@jar-stripe jar-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is deprecated used?

@prathmesh-stripe
Copy link
Contributor Author

@jar-stripe
Copy link
Contributor

stripe/sdk-codegen#2552

ahh, so this is added in anticipation of generating new lines in stripe client that utilize deprecated?

Copy link
Contributor

@jar-stripe jar-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@prathmesh-stripe
Copy link
Contributor Author

Exactly. without it CI will remain broken on codegen: https://github.com/stripe/sdk-codegen/actions/runs/15472058592/job/43561104169?pr=2552

@prathmesh-stripe prathmesh-stripe enabled auto-merge (squash) June 5, 2025 17:08
@prathmesh-stripe prathmesh-stripe disabled auto-merge June 5, 2025 17:08
@prathmesh-stripe prathmesh-stripe enabled auto-merge (squash) June 6, 2025 19:26
@prathmesh-stripe prathmesh-stripe disabled auto-merge June 6, 2025 19:26
@prathmesh-stripe prathmesh-stripe merged commit 21bb0e0 into master Jun 6, 2025
15 of 16 checks passed
@prathmesh-stripe prathmesh-stripe deleted the prathmesh/add-new-import-for-v1-services-2 branch June 6, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants