Support vue hybrid mode #265
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
reviewed
Aug 5, 2025
Comment on lines
+36
to
+44
| @classmethod | ||
| def on_pre_start( | ||
| cls, | ||
| window: sublime.Window, | ||
| initiating_view: sublime.View, | ||
| workspace_folders: list[WorkspaceFolder], | ||
| configuration: ClientConfig, | ||
| ) -> str | None: | ||
| cls._support_vue_hybrid_mode(configuration) |
There was a problem hiding this comment.
Problems:
- This will not trigger until one opens a supported file type (ts/js/..). So none of this logic will run when just opening a *.vue file.
- This changes global LSP-typescript settings so the vue plugin will be enabled for every project/file once some *.vue file is opened. Doesn't seem ideal. I wouldn't trust the vue plugin enough to enable it at all times, for all projects.
There was a problem hiding this comment.
This will not trigger until one opens a supported file type (ts/js/..). So none of this logic will run when just opening a *.vue file.
Is the simple solution to manually add text.html.vue to LSP-typescript selector setting? Maybe this could be mentioned in installation instructions as prerequisite step.
There was a problem hiding this comment.
Maybe we should avoid all the magic if we can: sublimelsp/LSP-vue#136 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR for LSP-vue.