some core additions #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudar
reviewed
Jul 28, 2017
| @@ -21,7 +21,9 @@ extends cpp | |||
| snippet setup "setup()" | |||
| void setup() | |||
| { | |||
| ${1} | |||
| ${1}//Serial.begin(115200); | |||
There was a problem hiding this comment.
Any specific reason for having a commented out code?
There was a problem hiding this comment.
I commented it out by default because you don't always need serial communication, but I also set the first point there so people can uncomment it very easily
|
Thanks for your PR. I just left a comment about the commented out code. Once that is fixed I would be happy to merge this. |
|
I commented it out by default because you don't always need serial communication, but I also set the first point there so people can uncomment it very easily |
|
Thanks for the Pull Request. I just merged it. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I added some arduino functions that were missing in your original plugin like
analogRead, serial.*, and brancing
Still missling for and while but they are in the works