chore: prefetch storybook cli during CI tests #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vast majority of our flakiness when we run tests in CI is due to some weird storybook cli error related to fetching (i think).
This PR serves as a quick test to see if we can at least alleviate some of the flakiness by prefetching the CLI before we run our test suite so it's stored in pnpm's cache.
edit:
This seems to work. Rerunning the tests in CI has yielded no errors and is 10/11 on successful runs (one of the runs failed because of a vitest
onTaskUpdateerror with mdsvex, so it's unrelated).