Skip to content

fix(no-unused-svelte-ignore): ignore reactive-component warnings #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(no-unused-svelte-ignore): ignore reactive-component warnings #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df2a1c6
fix(no-unused-svelte-ignore): ignore reactive-component warnings
ota-meshi Apr 30, 2025
c78608b
Create three-turkeys-marry.md
ota-meshi Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/three-turkeys-marry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-svelte": patch
---

fix(no-unused-svelte-ignore): ignore reactive-component warnings
10 changes: 10 additions & 0 deletions packages/eslint-plugin-svelte/src/rules/no-unused-svelte-ignore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import { getSvelteCompileWarnings } from '../shared/svelte-compile-warns/index.j
import { createRule } from '../utils/index.js';
import type { IgnoreItem } from '../shared/svelte-compile-warns/ignore-comment.js';
import { getSvelteIgnoreItems } from '../shared/svelte-compile-warns/ignore-comment.js';
import { VERSION as SVELTE_VERSION } from 'svelte/compiler';
import semver from 'semver';

export default createRule('no-unused-svelte-ignore', {
meta: {
Expand Down Expand Up @@ -46,6 +48,14 @@ export default createRule('no-unused-svelte-ignore', {
}

for (const unused of warnings.unusedIgnores) {
if (unused.code === 'reactive-component' && semver.satisfies(SVELTE_VERSION, '<5')) {
// Svelte v4 `reactive-component` warnings are not emitted
// when we use the `generate: false` compiler option.
// This is probably not the intended behavior of Svelte v4, but it's not going to be fixed,
// so as a workaround we'll ignore the `reactive-component` warnings.
// See https://github.com/sveltejs/eslint-plugin-svelte/issues/1192
continue;
}
context.report({
loc: {
start: sourceCode.getLocFromIndex(unused.range[0]),
Expand Down
15 changes: 15 additions & 0 deletions ...svelte/tests/fixtures/rules/no-unused-svelte-ignore/valid/reactive-component-input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<script lang="ts">
import { onMount } from 'svelte'

let MyComponent: typeof import('./MyComponent.svelte').default | undefined
onMount(() => {
import('./MyComponent.svelte').then((component) => {
MyComponent = component.default
})
})
</script>

{#if MyComponent}
<!-- svelte-ignore reactive-component -->
<MyComponent />
{/if}
3 changes: 3 additions & 0 deletions ...e/tests/fixtures/rules/no-unused-svelte-ignore/valid/reactive-component-requirements.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"svelte": "^4"
}
Loading