Skip to content

fix(no-top-level-browser-globals): false positives for compound logical expression guards #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 8, 2025
Merged

fix(no-top-level-browser-globals): false positives for compound logical expression guards #1305

merged 4 commits into from
Sep 8, 2025
+40 −8

Conversation

ota-meshi
Copy link
Member

fixes #1298

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 1ecb1ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025 •
edited
Loading

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@1ecb1ff

Published Instant Preview Packages:

View Commit

@ota-meshi ota-meshi force-pushed the fix-no-top-level-browser-globals branch from 7dfabba to 7459735 Compare September 3, 2025 05:19
baseballyama
baseballyama reviewed Sep 7, 2025
View reviewed changes
Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related original issue, but below case should be ok, but I got a report.

<script>
	import { browser, dev } from '$app/environment';
</script>

{#if browser || (dev && browser)}
	<div>{localStorage.getItem('myCat')}</div>
{/if}

@ota-meshi
Copy link
Member Author 

<script>
	import { browser, dev } from '$app/environment';
</script>

{#if browser || (dev && browser)}
	<div>{localStorage.getItem('myCat')}</div>
{/if}

Hmm. That would require checking all the condition paths, which is quite difficult, so I think we need to tackle it as a separate problem. What do you think?

@baseballyama baseballyama merged commit d92dde0 into main Sep 8, 2025
17 checks passed
@baseballyama baseballyama deleted the fix-no-top-level-browser-globals branch September 8, 2025 10:06
This was referenced Sep 8, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baseballyama baseballyama baseballyama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive for no-top-level-browser-globals with compound expression
2 participants
@ota-meshi @baseballyama