Skip to content

fix: support assets-only workers in wrangler validation #14019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2025
Merged

fix: support assets-only workers in wrangler validation #14019

merged 3 commits into from
Jul 22, 2025

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Jul 19, 2025

Fixes #14018.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 129b4ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

eltigerchino
eltigerchino approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this and sorry for breaking this in the first place. I've added some unit tests to ensure this doesn't happen again.

@eltigerchino eltigerchino merged commit 683c12d into sveltejs:main Jul 22, 2025
18 checks passed
@github-actions github-actions bot mentioned this pull request Jul 22, 2025
Merged
@kevinji kevinji deleted the patch-1 branch July 22, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eltigerchino eltigerchino eltigerchino approved these changes

Assignees
No one assigned
Labels
pkg:adapter-cloudflare
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assets-only workers broken by assets validation
3 participants
@kevinji @eltigerchino @benmccann